Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: Enable custom paths for light client proof verifications #1273

Merged
merged 15 commits into from
Jul 12, 2024
Merged

imp: Enable custom paths for light client proof verifications #1273

merged 15 commits into from
Jul 12, 2024

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Jul 10, 2024 •
edited
Loading

Closes: #1255
Closes: #1275

Integration tests: informalsystems/basecoin-rs#188

PR author checklist:

  • Added changelog entry, using unclog.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani mentioned this pull request Jul 10, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.16541% with 45 lines in your changes missing coverage. Please review.

Project coverage is 67.43%. Comparing base (0202dec) to head (426ca15).

Files Patch % Lines
ibc-core/ics24-host/types/src/path.rs 17.64% 14 Missing ⚠️
...lients/ics07-tendermint/src/client_state/common.rs 45.83% 13 Missing ⚠️
ibc-core/ics23-commitment/types/src/merkle.rs 33.33% 10 Missing ⚠️
ibc-clients/cw-context/src/types/msgs.rs 0.00% 6 Missing ⚠️
ibc-clients/cw-context/src/handlers.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1273      +/-   ##
==========================================
+ Coverage   67.40%   67.43%   +0.02%     
==========================================
  Files         235      236       +1     
  Lines       23828    23940     +112     
==========================================
+ Hits        16062    16144      +82     
- Misses       7766     7796      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani changed the title imp: Enable using custom binary paths for light client proof verification imp: Enable custom paths for light client proof verifications Jul 10, 2024
@Farhad-Shabani Farhad-Shabani added this to the 0.54.0 milestone Jul 10, 2024
@Farhad-Shabani Farhad-Shabani requested a review from rnbguy July 10, 2024 17:18
@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review July 10, 2024 17:18
This was referenced Jul 10, 2024
Closed
Closed
rnbguy
rnbguy approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the last comments. 🙌 We should also check the latest changes with basecoin-rs.

Otherwise, LGTM ✨

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit e36015c Jul 12, 2024
19 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/enable-custom-path branch July 12, 2024 15:10
This was referenced Jul 13, 2024
Closed
Closed
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani @rnbguy
imp: Enable custom paths for light client proof verifications (#1273)
2fff4a3 
* refactor: allow using custom path for light client proof verification

* imp: 2nd try, place serialize_path under the ClientStateCommon

* feat: define concat() for PathBytes

* fix: update cw-check cargo.lock

* chore: add docs and unclog

* misc: apply some fixes

* imp: group serialize_path and verify_(non_)membership_raw methods

* nit: reword changelog

* fix grammar

* imp: rename to flatten + revert to Path::*(*)

* fix typo

* fix: make clippy happy

* fix: move changelog to features

---------

Co-authored-by: Ranadeep Biswas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnbguy rnbguy rnbguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ibc-rs
Status: ✅ Done
Milestone
0.54.0
2 participants
@Farhad-Shabani @rnbguy